Merged
Conversation
Craigacp
approved these changes
Nov 18, 2020
JimClarke5
added a commit
to JimClarke5/java
that referenced
this pull request
Nov 19, 2020
Fix Javadoc errors (tensorflow#152)
rnett
pushed a commit
to rnett/tensorflow-java
that referenced
this pull request
Dec 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JimClarke5 , FYI, I had to fix a few errors in the new Javadoc merged with #129 or it was preventing the deployment to OSSRH, as you can see in this build.
Javadoc generation by maven was only enabled during deployment because it takes time to generate and I wanted to prevent our native builds on GitHub Actions to timeout because of this when it is not required, since we are so close of the 6 hours limit. But now, I'll reactivate it at least when using the
-Pdevprofile so the developers can be aware beforehand of these errors.I'll merge right away this PR since I've already redeploy the artifacts locally based on these changes.
Thanks,
Karl