Make Ops classes accessible from sub-Ops classes#150
Merged
karllessard merged 2 commits intotensorflow:masterfrom Nov 19, 2020
Merged
Make Ops classes accessible from sub-Ops classes#150karllessard merged 2 commits intotensorflow:masterfrom
karllessard merged 2 commits intotensorflow:masterfrom
Conversation
…ope, and get the scope from that. Save Ops parameter to field and add accessor for it. Signed-off-by: Ryan Nett <rnett@calpoly.edu>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
karllessard
reviewed
Nov 16, 2020
tensorflow-core/tensorflow-core-api/src/gen/annotations/org/tensorflow/op/AudioOps.java
Show resolved
Hide resolved
karllessard
reviewed
Nov 16, 2020
tensorflow-core/tensorflow-core-api/src/gen/annotations/org/tensorflow/op/LinalgOps.java
Show resolved
Hide resolved
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
karllessard
approved these changes
Nov 19, 2020
Collaborator
|
Thanks for the contribution @rnett ! |
rnett
added a commit
to rnett/tensorflow-java
that referenced
this pull request
Dec 28, 2020
* Adjust sub-Ops classes to take Ops in their constructor instead of Scope, and get the scope from that. Save Ops parameter to field and add accessor for it. Signed-off-by: Ryan Nett <rnett@calpoly.edu> * remove unlinked LinalgSparseOps Signed-off-by: Ryan Nett <rnett@calpoly.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adjust codegen to make ops group classes take Ops instead of Scope, get their Scope from it, save it in a field (
ops), and provide an accessor for that field (ops()).Fixes #147.