Fix decoding of string length#138
Merged
karllessard merged 1 commit intotensorflow:masterfrom Oct 30, 2020
Merged
Conversation
Contributor
Author
|
Can you pleeeease make a release with this soonish? This is the only issue that stops us from switching to these awesome new bindings. |
Collaborator
|
Hi @brychcy, I would honestly be pleased to unblock you that quickly but our release process is not currently up-to-speed and I personally don't have the bandwidth for doing another one right now (releasing projects with native artifacts like TF is not as straightforward as any standard Java/Maven projects) I'm following up with Google right now to get more resources available so we can do quick releases like this. Hopefully, these will be unblocked soon, I'll let you know. cc\ @joanafilipa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When turning tensors with length > 127 into java Strings, they were truncated.
Patch contains an added test case with an example.