[udf] Add udagg ARRAY_AGG base class and examples #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemeow
reviewed
Oct 11, 2022
| * ARRAY_AGG 示例：数据类型为 {@code Row<f1 bigint, f2 string>}. 使用方法：{@code CREATE TEMPORARY SYSTEM | ||
| * FUNCTION ARRAY_AGG AS 'com.tencent.cloud.oceanus.udf.RowArrayAgg1' LANGUAGE JAVA;} | ||
| */ | ||
| public class RowArrayAgg1 extends ArrayAgg<RowData> { |
Contributor
Author
There was a problem hiding this comment.
示例代码，Row的内容具体化了。如果用户的 Row 内容不一样，需要用户开发一个 2、3 之类的。
Collaborator
There was a problem hiding this comment.
建议更新一下 README.md，增加 ArrayAgg 类函数的说明
kylemeow
reviewed
Oct 11, 2022
| @@ -0,0 +1,158 @@ | |||
| /* | |||
| * Licensed to the Apache Software Foundation (ASF) under one | |||
Collaborator
There was a problem hiding this comment.
项目不是 Apache 名下，无需添加这个 License Header
kylemeow
reviewed
Oct 11, 2022
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| /** ARRAY_AGG 基类. */ |
Collaborator
There was a problem hiding this comment.
代码借鉴了开源的 Flink，需要加上出处说明（credits）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.