Dev log sink refactor #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemeow
requested changes
Sep 16, 2021
| @Override | ||
| public SinkRuntimeProvider getSinkRuntimeProvider(Context context) { | ||
| return SinkFunctionProvider.of(new Slf4jSink<>(printIdentifier)); | ||
| Slf4jSink.Builder build = Slf4jSink.builder().setFieldDataTypes(tableSchema.getFieldDataTypes()).setPrintIdentifier(printIdentifier); |
| Method m1 = null; | ||
| CatalogTable table = null; | ||
| try { | ||
| m1 = clazz.getDeclaredMethod("getCatalogTable"); |
| public void invoke(T value, Context context) { | ||
| StringBuilder builder = new StringBuilder(); | ||
| builder.append(printIdentifier); | ||
| builder.append("====== " + printIdentifier); |
Collaborator
There was a problem hiding this comment.
"====== " 太长了，已经有 printIdentifier 了就可以不用了吧
added 2 commits
September 16, 2021 17:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
采用 RowData::FieldGetter 来获取RowData里面的字段。
不同flink版本打包时候，要修改pom里的flink版本号