Add 'print-identifier' parameter to logger sink

Yuntao-Wu · web-flow · commit 478ca3de8f06 · 2021-07-14T19:11:07.000+08:00
diff --git a/src/main/java/com/tencent/cloud/oceanus/sink/LoggerTableSinkFactory.java b/src/main/java/com/tencent/cloud/oceanus/sink/LoggerTableSinkFactory.java
@@ -20,13 +20,16 @@
 
 import org.apache.flink.annotation.PublicEvolving;
 import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.configuration.ReadableConfig;
 import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException;
 import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
 import org.apache.flink.streaming.api.functions.sink.SinkFunction;
 import org.apache.flink.table.connector.ChangelogMode;
 import org.apache.flink.table.connector.sink.DynamicTableSink;
 import org.apache.flink.table.connector.sink.SinkFunctionProvider;
 import org.apache.flink.table.factories.DynamicTableSinkFactory;
+import org.apache.flink.table.factories.FactoryUtil;
 import org.apache.flink.types.RowKind;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -41,7 +44,12 @@
 @PublicEvolving
 public class LoggerTableSinkFactory implements DynamicTableSinkFactory {
 
-	public static final String IDENTIFIER = "logger";
+    public static final String IDENTIFIER = "logger";
+    public static final ConfigOption<String> PRINT_IDENTIFIER = ConfigOptions
+            .key("print-identifier")
+            .stringType()
+            .defaultValue("")
+            .withDescription("Message that identify logger and is prefixed to the output of the value.");
 
 	@Override
 	public String factoryIdentifier() {
@@ -53,17 +61,29 @@ public Set<ConfigOption<?>> requiredOptions() {
 		return new HashSet<>();
 	}
 
-	@Override
-	public Set<ConfigOption<?>> optionalOptions() {
-		return new HashSet<>();
-	}
+    @Override
+    public Set<ConfigOption<?>> optionalOptions() {
+        Set<ConfigOption<?>> optionalOptions = new HashSet<>();
+        optionalOptions.add(PRINT_IDENTIFIER);
+        return optionalOptions;
+    }
 
-	@Override
-	public DynamicTableSink createDynamicTableSink(Context context) {
-		return new LoggerSink();
-	}
+    @Override
+    public DynamicTableSink createDynamicTableSink(Context context) {
+        final FactoryUtil.TableFactoryHelper helper = FactoryUtil.createTableFactoryHelper(this, context);
+        final ReadableConfig options = helper.getOptions();
+        helper.validate();
 
-	private static class LoggerSink implements DynamicTableSink {
+        return new LoggerSink(options.get(PRINT_IDENTIFIER));
+    }
+
+    private static class LoggerSink implements DynamicTableSink {
+
+        private final String printIdentifier;
+
+        public LoggerSink(String printIdentifier) {
+            this.printIdentifier = printIdentifier;
+        }
 
 		@Override
 		public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
@@ -76,15 +96,15 @@ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
 			return builder.build();
 		}
 
-		@Override
-		public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
-			return SinkFunctionProvider.of(new Slf4jSink<>());
-		}
+        @Override
+        public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
+            return SinkFunctionProvider.of(new Slf4jSink<>(printIdentifier));
+        }
 
-		@Override
-		public DynamicTableSink copy() {
-			return new LoggerSink();
-		}
+        @Override
+        public DynamicTableSink copy() {
+            return new LoggerSink(printIdentifier);
+        }
 
 		@Override
 		public String asSummaryString() {
@@ -94,19 +114,29 @@ public String asSummaryString() {
 }
 
 class Slf4jSink<T> implements SinkFunction<T> {
-	private static final Logger LOGGER = LoggerFactory.getLogger(Slf4jSink.class);
-	private static final ObjectMapper MAPPER = new ObjectMapper();
-
-	private static final long serialVersionUID = 1L;
-
-	@Override
-	public void invoke(T value) {
-		String jsonString = "";
-		try {
-			jsonString = MAPPER.writeValueAsString(value);
-		} catch (JsonProcessingException e) {
-			LOGGER.debug("Unable to serialize value into JSON", e);
-		}
-		LOGGER.info("toString: {}, JSON: {}", value.toString(), jsonString);
-	}
+    private static final long serialVersionUID = 1L;
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(Slf4jSink.class);
+    private static final ObjectMapper MAPPER = new ObjectMapper();
+    private final String printIdentifier;
+
+    public Slf4jSink(String printIdentifier) {
+        this.printIdentifier = printIdentifier;
+    }
+
+    @Override
+    public void invoke(T value, Context context) {
+        StringBuilder builder = new StringBuilder();
+        builder.append(printIdentifier);
+
+        try {
+            builder.append("-toString: ");
+            builder.append(value.toString());
+            builder.append(", JSON: ");
+            builder.append(MAPPER.writeValueAsString(value));
+        } catch (JsonProcessingException e) {
+            LOGGER.debug("{}-Unable to serialize value into JSON", printIdentifier, e);
+        }
+        LOGGER.info(builder.toString());
+    }
 }
