fix: preserve comments in workspace.jsonc when updating config#9851
Merged
Conversation
When using setExtension with mergeIntoExisting:true (e.g., via 'bit scope set'), comments within aspect objects were being lost due to JavaScript spread operator destroying comment-json metadata. Fixed by using assign() from comment-json library to merge properties while preserving all comments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
GiladShoham
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where comments in workspace.jsonc were lost when using bit commands such as
bit scope set. The spread operator was destroying comment metadata from comment-json. Fixed by usingassign()to preserve comments during property merging. Added e2e test to prevent regression.