Add empty param name support#10
Merged
s3rius merged 4 commits intotaskiq-python:developfrom Aug 23, 2023
Merged
Conversation
Member
|
@cofob, thanks you very much for contribution. I have an Idea. I guess, it would be really nice to create a separate function that sets this parameter to EMPTY_PARAM_NAME and do not expose the constant to users. You may call it As I see it, it would be easier since you would not need to import anything and it would be easier to maintain backward compatibility. async def main() -> None:
# Never forget to call startup in the beginning.
await broker.startup()
pipe = Pipeline(broker, add_one).call_after(do_nothing)
task = await pipe.kiq(2)
await asyncio.sleep(2)What do you think? |
Contributor
Author
|
@s3rius added call_after. Please review. |
6605d63 to
ad62ed3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test code: