Merged
Conversation
Signed-off-by: Pavel Kirilin <win10@list.ru>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #243 +/- ##
===========================================
+ Coverage 77.20% 77.75% +0.55%
===========================================
Files 60 61 +1
Lines 1750 1789 +39
===========================================
+ Hits 1351 1391 +40
+ Misses 399 398 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@asvetlov, mind taking a look at the request? I'd be very grateful, since this functionality affects your PR as well. Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was highlighted by @asvetlov in the taskiq-python/taskiq-pipelines#14.
I was thinking about possible APIs for implementation this functionality and came up with this one. Now, along with dict of labels we store dict of labels types. To minimize amount of space for this information I've chosen to use ints over anything else. This solution is not perfect, but it's the most elegant solution I could come up with.
Possible improvements for the future:
parse_labelsmethod fromTaskiqMessageand move it somewhere else (possibly in formatters)This request should be backward compatible, but might brake some custom middlewares.