Fix potential bug with incorrect recycling of block of memory across dll boundary#728
Open
olologin wants to merge 1 commit intotaskflow:masterfrom
Open
Fix potential bug with incorrect recycling of block of memory across dll boundary#728olologin wants to merge 1 commit intotaskflow:masterfrom
olologin wants to merge 1 commit intotaskflow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar problem to what was shown with this_worker, but this time it is because graph.hpp defines ObjectPool object statically, which results in each dll having its own version of object pool, and then recycling is not going to work correctly because it may refer to
_gheapobject of the current dll, while recycling block that belongs to_gheapof another dll.