Skip to content

Make code compatible with Python3#181

Merged
Totktonada merged 2 commits intomasterfrom
ligurio/support-python3
Dec 1, 2020
Merged

Make code compatible with Python3#181
Totktonada merged 2 commits intomasterfrom
ligurio/support-python3

Conversation

@ligurio
Copy link
Member

@ligurio ligurio commented Nov 25, 2020

No description provided.

@ligurio ligurio mentioned this pull request Nov 25, 2020
Closed
@Totktonada
Copy link
Contributor

Totktonada commented Nov 25, 2020

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Say, unittest.TestCase contains both assertRaisesRegexp() and assertRaisesRegex() on Python 3.7.6. Even if it would not, we don't need a library to make the simple alias. x.items() from Python 2 is the same as list(x.items()) in Python 3, but it does not meant that you need to follow py2to3 everywhere it suggest you to do so. Mostly it is just doesn't necessary and a view on a mapping object is what you need.

Please, pay attention to don't break Python 2 code.

If I'm too early here, I suggest to mark the PR as draft.

@ligurio ligurio force-pushed the ligurio/support-python3 branch 2 times, most recently from 81b5fd4 to 46c565b Compare November 25, 2020 10:34
@ligurio ligurio requested a review from Totktonada November 25, 2020 11:37
@ligurio
Copy link
Member Author

ligurio commented Nov 25, 2020

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Yep, code is actually already compatible with Python 3. There are only two places required to fix: print calls and exec call. Please review these two patches. CI is green.

Please, pay attention to don't break Python 2 code.

Sure.

Totktonada
Totktonada reviewed Nov 27, 2020
View reviewed changes
Totktonada
Totktonada reviewed Nov 27, 2020
View reviewed changes
@ligurio
test: make print calls compatible with Python 3.x
cb33676 
In a Python 3 'print' becomes a function, see [1].
Patch makes print calls compatible with Python 3.

1. https://docs.python.org/3/whatsnew/3.0.html#print-is-a-function
@ligurio
make exec call compatible with Python 3.x
7a870fa 
exec was a statement in Python 2.x [1] and it has been converted to a function
in Python 3.x [2], change introduced in version 3.0 [3].

1. https://docs.python.org/2/reference/simple_stmts.html#exec
2. https://docs.python.org/3/library/functions.html#exec
3. https://docs.python.org/3/whatsnew/3.0.html
@ligurio ligurio force-pushed the ligurio/support-python3 branch from 46c565b to 7a870fa Compare November 27, 2020 08:42
Totktonada
Totktonada approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Totktonada Totktonada merged commit 37d5f89 into master Dec 1, 2020
@Totktonada Totktonada deleted the ligurio/support-python3 branch December 1, 2020 07:44
@ligurio ligurio mentioned this pull request Dec 29, 2020
Closed
14 tasks
ligurio added a commit to tarantool/test-run that referenced this pull request Jan 16, 2021
@ligurio
python3: avoid hardcode of arbitrary python version
7f136b0 
Related issues:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Jan 18, 2021
@ligurio
python3: use default python version in shebang
6cd8586 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Jan 19, 2021
@ligurio
python3: use default python version in shebang
41d40a7 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Jan 22, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
f872ef3 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 1, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
9a2f4aa 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 3, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
4ef44c8 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 4, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
d6e6ca4 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 4, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
4af31fe 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 4, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
248f878 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
37a4fee 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
c6d6c9a 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
fbd6251 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
2950da1 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
e3914bb 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 8, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
a246112 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 8, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
417eb25 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Feb 11, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
2ba463e 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 4, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
b23ba1a 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 5, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
904b271 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 6, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
e4cb121 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 6, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
7be2510 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 9, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
b264f06 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 9, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
0d5d3b0 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 9, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
145fe78 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 9, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
279c781 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 9, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
c1de64b 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 10, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
3c3a1a0 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 10, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
0c905bf 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 10, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
eecbd70 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 12, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
bcba5f7 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
ligurio added a commit to tarantool/test-run that referenced this pull request Mar 12, 2021
@ligurio
python3: use python 3 in test-run.py's shebang
a8c221f 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
Totktonada pushed a commit to tarantool/test-run that referenced this pull request Mar 12, 2021
@ligurio @Totktonada
python3: use python 3 in test-run.py's shebang
e93d067 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
Totktonada pushed a commit to tarantool/test-run that referenced this pull request Mar 13, 2021
@ligurio @Totktonada
python3: use python 3 in test-run.py's shebang
5baa4f0 
Related issues and changes:

- Support Python 3 in Tarantool test suite
  tarantool/tarantool#5538
- Python 3 in tarantool-python
  tarantool/tarantool-python#181
  tarantool/tarantool-python#186
- Use Python 3 in a test infrastructure
  tarantool/tarantool#5652

Closes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Totktonada Totktonada Totktonada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ligurio @Totktonada