Merged
Conversation
artembo
added a commit
that referenced
this pull request
Jul 17, 2020
* added dbapi2 errors and extended Cursor and Connection functionality * disable quoting for boolean query params * updated connection and response * workaround for update and insert * workaround for lastrowid * implemented fetchone logic * minor changes * minor changes and added dbapi2 descriptions * set use_list to False for Response object
Merged
artembo
added a commit
that referenced
this pull request
Aug 20, 2020
* added dbapi2 errors and extended Cursor and Connection functionality * disable quoting for boolean query params * updated connection and response * workaround for update and insert * workaround for lastrowid * implemented fetchone logic * minor changes * minor changes and added dbapi2 descriptions * set use_list to False for Response object
artembo
added a commit
that referenced
this pull request
Aug 20, 2020
* added dbapi2 errors and extended Cursor and Connection functionality * disable quoting for boolean query params * updated connection and response * workaround for update and insert * workaround for lastrowid * implemented fetchone logic * minor changes * minor changes and added dbapi2 descriptions * set use_list to False for Response object * created Cursor and Connection classes Co-authored-by: Denis Ignatenko <denis.ignatenko@gmail.com>
artembo
added a commit
that referenced
this pull request
Aug 20, 2020
* added dbapi2 errors and extended Cursor and Connection functionality * disable quoting for boolean query params * updated connection and response * workaround for update and insert * workaround for lastrowid * implemented fetchone logic * minor changes * minor changes and added dbapi2 descriptions * set use_list to False for Response object * created Cursor and Connection classes Co-authored-by: Denis Ignatenko <denis.ignatenko@gmail.com>
artembo
added a commit
that referenced
this pull request
Aug 21, 2020
* added dbapi2 errors and extended Cursor and Connection functionality * disable quoting for boolean query params * updated connection and response * workaround for update and insert * workaround for lastrowid * implemented fetchone logic * minor changes * minor changes and added dbapi2 descriptions * set use_list to False for Response object * created Cursor and Connection classes Co-authored-by: Denis Ignatenko <denis.ignatenko@gmail.com>
artembo
added a commit
that referenced
this pull request
Aug 21, 2020
Implemented dbapi2 interface in dbapi module. See [1] for details. The main motivation for the module creation was the integration Django with Tarantool database through django-tarantool database backend [2] which requires dbapi connector to the database. All the optional extensions and methods were ignored because Django does not require them. Anyway, fell free to suggest its implementation as needed. Unit tests were taken from dbapi-compliance [3] package. Interactive transactions are not currently supported by Tarantool and theirs implementation will be added in the connector when the feature is stable it Tarantool itself. [1] https://www.python.org/dev/peps/pep-0249/ [2] https://github.com/artembo/django-tarantool [3] https://github.com/baztian/dbapi-compliance/ Co-authored-by: Denis Ignatenko <denis.ignatenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented basic dbapi2.0 methods without transactions support