Conversation
…sgpack 1.0 makes the driver unable to parse server response
|
In CI:
It seems we should support both old and new implementations. |
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
Please, squash commits and explain changes in the commit message (just like you did for the PR description). Don't forget to include Fixes #155 or Closes #155 tag.
See also the comment below.
| if msgpack.version >= (1, 0, 0): | ||
| unpacker = msgpack.Unpacker(use_list=True, raw=False, strict_map_key=False) | ||
| else: | ||
| unpacker = msgpack.Unpacker(use_list=True, raw=False) | ||
| elif conn.encoding is not None: | ||
| unpacker = msgpack.Unpacker(use_list=True, encoding=conn.encoding) | ||
| if msgpack.version >= (1, 0, 0): | ||
| unpacker = msgpack.Unpacker(use_list=True, encoding=conn.encoding, strict_map_key=False) | ||
| else: | ||
| unpacker = msgpack.Unpacker(use_list=True, encoding=conn.encoding) | ||
| else: | ||
| unpacker = msgpack.Unpacker(use_list=True) | ||
| if msgpack.version >= (1, 0, 0): | ||
| unpacker = msgpack.Unpacker(use_list=True, strict_map_key=False) | ||
| else: | ||
| unpacker = msgpack.Unpacker(use_list=True) |
There was a problem hiding this comment.
We can reduce code duplication by unpacking a dictionary to keyword parameters. A kind of this (not tested):
kwargs = dict(use_list=True)
if msgpack.version >= (1, 0, 0):
# XXX: Explain why it is necessary.
kwargs['strict_map_key'] = False
if msgpack.version >= (0, 5, 2) and conn.encoding == 'utf-8':
# Get rid of the following warning.
# > PendingDeprecationWarning: encoding is deprecated,
# > Use raw=False instead.
kwargs['raw'] = False
elif conn.encoding is not None:
kwargs['encoding'] = conn.encoding
unpacker = msgpack.Unpacker(**kwargs)
Totktonada
changed the title
|
From python-msgpack 1.0.0 release notes:
Are'we affected by this? |
In fact, no:
|
|
Closed in favor of PR #173. |
2 participants
In msgpack 1.0.0, the default value of strict_map_key is changed to True to avoid hashdos. However, it will break the Tarantool driver, causing an exception:
As a result, the driver is unable to parse server response. The issue is reported at #155