[backport 3.3] coro: do not clear rbp in coro_init#12275
Open
TarantoolBot wants to merge 1 commit intorelease/3.3from
Open
[backport 3.3] coro: do not clear rbp in coro_init#12275TarantoolBot wants to merge 1 commit intorelease/3.3from
rbp in coro_init#12275TarantoolBot wants to merge 1 commit intorelease/3.3from
Conversation
Currently `rbp` register is cleared in `coro_init()` to stop unwinding. However, despite the fact that this register is present in the clobber list, and `coro.c` is compiled with `-fomit-frame-pointer`, a compiler tries to use `rbp`. It seems that zeroing out of `rbp` is actually not required. This patch reverts a part of commit 761053f ("coro: fix `coro_{init,startup}` unwind information"). Closes #12216 NO_DOC=bugfix NO_CHANGELOG=internal NO_TEST=hard to create a stable reproducer (cherry picked from commit f34fbff)
TarantoolBot
changed the title
rbp in coro_initrbp in coro_init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #12266 to
release/3.3to a future3.3.5release.)Currently
rbpregister is cleared incoro_init()to stop unwinding. However, despite the fact that this register is present in the clobber list, andcoro.cis compiled with-fomit-frame-pointer, a compiler tries to userbp.It seems that zeroing out of
rbpis actually not required. This patch reverts a part of commit 761053f ("coro: fixcoro_{init,startup}unwind information").Closes #12216