[backport 3.3] datetime: calculated plan of c unit tests#12256
Open
tmr-g wants to merge 4 commits intotarantool:release/3.3from
Open
[backport 3.3] datetime: calculated plan of c unit tests#12256tmr-g wants to merge 4 commits intotarantool:release/3.3from
tmr-g wants to merge 4 commits intotarantool:release/3.3from
Conversation
tmr-g
requested review from
Buristan and
grafin
and removed request for
Buristan
The tests commented will fail with changes from tarantool#12096: > The actual result type `ssize_t` of `datetime_parse_full` is used to fix the error detecion. These tests produce negative result, which looks as "good" in an unsigned var. This commit is a target for revert when tarantoolgh-12095 would fixed. Need for tarantool#12096 Part of tarantool#12095 NO_DOC=tests NO_CHANGELOG=tests (cherry picked from commit 49eea0e)
The tests producing negative result looks as "good" in an unsigned var. The actual result type `ssize_t` of `datetime_parse_full` is used to fix the error detecion. Needed tarantool#12103 Part of tarantool#12095 NO_DOC=tests NO_CHANGELOG=tests (cherry picked from commit 510e0b0)
NO_TEST=comments NO_CHANGELOG=comments NO_DOC=comments (cherry picked from commit a8c002d)
Some datetime.c unit tests refactored to simpilfy it's support. The number of tap test checks is being calculated using the length of test data tables. NO_DOC=tests NO_CHANGELOG=tests (cherry picked from commit f65a6c0)
tmr-g
force-pushed
the
backport/release/3.3/12142
branch
from
dc37be2 to
e0c6025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #12142 (4 -- main, mentioned in the title), #12140 (3 -- minor comment fix), #12096 (2 -- minor one line test fix), #12103 (1 -- minor test fix) to release/3.3)
(4) datetime: calculated plan of c unit tests #12142
Some datetime.c unit tests refactored to simpilfy it's support. The number of tap test checks is being calculated
using the length of test data tables.
Split from #12083
(3) datetime: clarified MOD/DIV desc in datetime.c #12140
Split from #12060
(2) datetime: fixed unit test checks for parse #12096
The tests producing negative result looks as "good" in an unsigned var.
The actual result type ssize_t of datetime_parse_full is used to fix the error detecion.
Needed #12103
Part of #12095
(1) datetime: unit tests temporary commented out #12103
The tests commented will fail with changes from #12096:
These tests produce negative result, which looks as "good" in an unsigned var.
This commit is a target for revert when #12095 would fixed.
Need for #12096
Part of #12095