Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rosszurowski
commented
Mar 21, 2023
| return new Response(feed, { | ||
| headers: { | ||
| 'Content-Type': 'application/xml', | ||
| 'Cache-Control': 'public, s-maxage=1200, stale-while-revalidate=600', |
Contributor
Author
There was a problem hiding this comment.
These cache values may need to be changed depending on what makes sense for the site.
Contributor
There was a problem hiding this comment.
This seems sensible to me.
This commit updates the RSS feeds to be generated at request time via an API route rather than at build time. I find this helps minimize the need for "post-build" steps and makes it easier to pull content from dynamic sources when working with Next.js.
rosszurowski
force-pushed
the
rosszurowski/rss
branch
from
23a889f to
f4877d9
Compare
Contributor
Author
|
Just rebased against |
Signed-off-by: Tyler Smalley <tyler@tailscale.com>
shayne
added a commit
that referenced
this pull request
Mar 28, 2023
This is causing the RSS feed to 500. https://tailscale.dev/feed.xml
Contributor
|
I had to revert this in #157 it was throwing a 500 when trying to access the RSS feed |
tylersmalley
added a commit
that referenced
this pull request
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the RSS feeds to be generated at request time via an API route rather than at build time. I find this helps minimize the need for "post-build" steps and makes it easier to pull content from dynamic sources when working with Next.js.
Feel free to reject if you'd rather keep doing it at build time.