Conversation
Erisa
force-pushed
the
erisa/devices-tun
branch
from
19a11d1 to
17c91ab
Compare
tomhjp
approved these changes
Dec 2, 2024
Member
tomhjp
left a comment
tomhjp
left a comment
There was a problem hiding this comment.
All the changes included look good, any reason not to include 03 and 04 as well though? Looks like they both use /dev/net/tun under volumes as well
Erisa
force-pushed
the
erisa/devices-tun
branch
from
17c91ab to
74c2bc4
Compare
Member
Author
|
Thanks @tomhjp I've added those two, my mistake! |
Member
|
Looks good! Thanks for getting this fixed up quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tailscale/tailscale#14256