fix(Form): Fix invalid properties for maxLength, minLength, autoComplete#440
Conversation
|
Please merge this ASAP! |
|
Any chance of getting this merged and released, @AaronCoplan ? Our console would be eternally grateful! 😬 |
joaquinwojcik
left a comment
joaquinwojcik
left a comment
There was a problem hiding this comment.
Excellent. It should be merged ASAP.
|
Who has the ability to merge this? |
|
@akabraham I think no one. Please plan B |
|
I meanwhile found that the library is badly designed overall (try to implement a logout button in the accounts dropdown). I use antd now. |
wolph
left a comment
wolph
left a comment
There was a problem hiding this comment.
I've tested this in Firefox and Chrome. The only issue I see is that it changes the autocomplete parameter to <Form> to autoComplete which can break peoples' code
|
@jonthomp Any chance of a merge / release of this? 😅 |
|
Sorry all I've been away for the last 4 weeks, updates, PR merging etc incoming... |
|
As it stands this should be a breaking change release unless we also keep the old props? Any thoughts/opinions on this? |
|
It's indeed a breaking change but fixing it is a one-off. I would assume that the manual parameters don't get much use in any case. It might be neater to support both but I believe it's a non-issue |
|
I think we should replace with camelCase as react requires camelCase, please see similar discussion in react repo: facebook/react#2882 |
# [1.30.0](v1.29.0...v1.30.0) (2019-06-01) ### Bug Fixes * **Form:** Fix invalid properties for maxLength, minLength, autoComplete ([d63f9c3](d63f9c3)) * **Form:** Fix invalid properties for maxLength, minLength, autoComplete ([#440](#440)) ([cb4a69a](cb4a69a)) * **package:** update d3-scale to version 3.0.0 ([e927826](e927826)) * **package:** update react-router-dom to version 5.0.0 ([464eea4](464eea4)) ### Features * **FileInput:** add accept property ([0965e51](0965e51)) * **StandAloneFormPage:** Made the logo variable ([2d9d48e](2d9d48e))
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
11 participants
Fix maxLength, minLength, autoComplete "Invalid DOM property" errors for Form element.
Fixes #434