Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

useExact for subNavItems#412

Merged
jonthomp merged 1 commit into
tabler:masterfrom
Thomas-Smyth:subNavItems-exact
Jun 1, 2019
Merged

useExact for subNavItems#412
jonthomp merged 1 commit into
tabler:masterfrom
Thomas-Smyth:subNavItems-exact

Conversation

@Thomas-Smyth
Copy link
Copy Markdown
Contributor

#407

I'm not sure if this is the best solution because of the additional prop added to the Dropdown.Item, so feedback would be appreciated!

@jonthomp
Copy link
Copy Markdown
Contributor

jonthomp commented Feb 4, 2019

@Thomas-Smyth I think this will be fine but perhaps rename the prop to just exact, or at least something different to useExact as the impending React Hooks revolution is about to be upon us and it might mislead people.

@Thomas-Smyth
Copy link
Copy Markdown
Contributor Author

@jonthomp would it be worth doing the same to the changes made in the previous PR regarding exact?

#383

@jonthomp
Copy link
Copy Markdown
Contributor

jonthomp commented Jun 1, 2019

I'm going to go ahead and merge this and deal with any naming issues when we get to them

@jonthomp jonthomp merged commit 542f1a3 into tabler:master Jun 1, 2019
@jonthomp
Copy link
Copy Markdown
Contributor

jonthomp commented Jun 1, 2019

🎉 This PR is included in version 1.30.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants