This repository was archived by the owner on Mar 1, 2024. It is now read-only.
feat(FormInput): add autoFocus to FormInput#375
Merged
Conversation
Contributor
|
Hey @nating , thanks for contributing! This looks good - would you mind just uploading a screenshot of it working? After that it'll be good to merge |
Contributor
Author
|
Sure, @AaronCoplan ! I tested it already but will get round to uploading a screenshot of the testing later on today 👌 |
Contributor
Author
|
@AaronCoplan , the following GIF demonstrates:
|
AaronCoplan
approved these changes
Nov 29, 2018
Contributor
AaronCoplan
left a comment
AaronCoplan
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the thorough demo!
Contributor
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds autoFocus prop to the FormInput component 👍😎