Add type hints for schedules#969
Merged
jacalata merged 14 commits intotableau:developmentfrom Jan 28, 2022
Merged
Conversation
commit b836f33 Author: Brian Cantoni <bcantoni@salesforce.com> Date: Thu Jan 27 19:29:50 2022 -0800 WIP: Enable Black for CI and add as dependency (tableau#935) * Enable Black for CI and add as dependency * Bulk reformat with Black, line length 120 Co-authored-by: Jac Fitzgerald <jac.fitzgerald@salesforce.com>
just make black do the formatting instead of watching it complain
fixing DailyInterval has no attribute 'interval'
mypy error: tableauserverclient/server/endpoint/schedules_endpoint.py:118: error: Argument 1 to "append" of "list" has incompatible type "Tuple[DatasourceItem, str, Callable[[Optional[str], str], bytes]]"; expected "Tuple[WorkbookItem, str, Callable[[Optional[str], str], bytes]]" [arg-type]
add back 'check'
jacalata
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Add type hints for schedules * Squashed commit of the following: commit b836f33 Author: Brian Cantoni <bcantoni@salesforce.com> Date: Thu Jan 27 19:29:50 2022 -0800 WIP: Enable Black for CI and add as dependency (#935) * Enable Black for CI and add as dependency * Bulk reformat with Black, line length 120 * Update interval_item.py fixing DailyInterval has no attribute 'interval'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type hints to schedule item and endpoint.