Skip to content

Fix Issue #73: Plumb Password to Update User #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t8y8 merged 1 commit into from
Oct 25, 2016
Merged

Fix Issue #73: Plumb Password to Update User #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tableauserverclient/models/user_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def __init__(self, name, site_role, auth_setting=None):
self._workbooks = None
self.email = None
self.fullname = None
self.password = None
self.name = name
self.site_role = site_role
self.auth_setting = auth_setting
Expand Down
4 changes: 2 additions & 2 deletions tableauserverclient/server/endpoint/users_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ def get_by_id(self, user_id):
return UserItem.from_response(server_response.content).pop()

# Update user
def update(self, user_item):
def update(self, user_item, password=None):
if not user_item.id:
error = "User item missing ID."
raise MissingRequiredFieldError(error)

url = "{0}/{1}".format(self.baseurl, user_item.id)
update_req = RequestFactory.User.update_req(user_item)
update_req = RequestFactory.User.update_req(user_item, password)
server_response = self.put_request(url, update_req)
logger.info('Updated user item (ID: {0})'.format(user_item.id))
updated_item = copy.copy(user_item)
Expand Down
2 changes: 1 addition & 1 deletion tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def add_req(self, tag_set):


class UserRequest(object):
def update_req(self, user_item, password=''):
def update_req(self, user_item, password):
xml_request = ET.Element('tsRequest')
user_element = ET.SubElement(xml_request, 'user')
if user_item.fullname:
Expand Down
1 change: 0 additions & 1 deletion test/test_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def test_update(self):
single_user.name = 'Cassie'
single_user.fullname = 'Cassie'
single_user.email = 'cassie@email.com'
single_user.password = 'password'
single_user = self.server.users.update(single_user)

self.assertEqual('Cassie', single_user.name)
Expand Down