Skip to content

Add support for PDF and CSV Export#236

Merged
t8y8 merged 7 commits intotableau:developmentfrom
t8y8:234-feature-new-exports
Sep 27, 2017
Merged

Add support for PDF and CSV Export#236
t8y8 merged 7 commits intotableau:developmentfrom
t8y8:234-feature-new-exports

Conversation

@t8y8
Copy link
Copy Markdown
Collaborator

@t8y8 t8y8 commented Sep 27, 2017

TODO:

  • Add all the options for PDF export (landscape, size)
  • Add tests for the new endpoints
  • Should PDF also return an iterable-stream?
  • How do we feel about csv returning an iterable-stream?
  • How do we feel about calling 'data' > 'csv' on the model?
  • Clean up error strings (They're find/replace right now)
  • Do we want to rename image to png?
  • I called 'type' for the pdf size 'output_size' but open to better names. I don't like type

/cc @RussTheAerialist

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants