Reword no_extract and update signature of added_in#144
Merged
t8y8 merged 1 commit intotableau:developmentfrom Feb 14, 2017
Merged
Reword no_extract and update signature of added_in#144t8y8 merged 1 commit intotableau:developmentfrom
t8y8 merged 1 commit intotableau:developmentfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the feature is to not download the extract, not to only download the extract.
Oops.
I also changed the way the
parameter_added_indecorator works after @RussTheAerialist recommended a little cleaner api.Again manually tested that it works like it should, plus it gets exercised by unittests already in place.