Claude review of PR #42136 (914c41a)

Must fix

• Unused FILE *f variable — src/shared/luo-util.c:142 — the _cleanup_fclose_ FILE *f declaration is now unused after switching to sd_json_parse_fd(), will fail with -Werror

Suggestions

• Missing fd validation — src/libsystemd/sd-json/sd-json.c:3540 — sd_json_parse_fd() lacks the assert_return(fd >= 0, -EBADF) that other public API functions consistently use
• Inaccurate file offset documentation — man/sd_json_parse.xml:165 — claims the caller's fd offset is left untouched, but F_DUPFD_CLOEXEC shares the offset with the original
• Missing history entries — man/sd_json_parse.xml:300 — SD_JSON_PARSE_MUST_BE_OBJECT and SD_JSON_PARSE_MUST_BE_ARRAY have v261 markers in the body but are missing from the History section

Nits

• Stale flags passed downstream — src/libsystemd/sd-json/sd-json.c:3565 — fd-specific flags are passed to sd_json_parse_file where they're meaningless; should be stripped like SD_JSON_PARSE_SEEK0 is
• Misleading error on fd reopen failure — src/resolve/resolved-static-records.c:99 — collapsing open+parse into one call means an fd reopen failure reports as "Failed to parse JSON file"
• Trivially-true ASSERT_NULL in tests (dismissed)

Workflow run

1 warning generated.
../src/core/luo.c:8:1: error: included header fileio.h is not used directly [misc-include-cleaner,-warnings-as-errors]
    8 | #include "fileio.h"
      | ^~~~~~~~~~~~~~~~~~~
    9 | #include "json-util.h"
Suppressed 1 warnings (1 NOLINT).
1 warning treated as error
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

2019/2838 clang-tidy - systemd:clang-tidy-networkd-serialize.c                        FAIL            0.35s   exit status 1
>>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=189 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 /usr/sbin/clang-tidy -p /home/runner/work/systemd/systemd/build /home/runner/work/systemd/systemd/build/../src/network/networkd-serialize.c
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
1 warning generated.
../src/network/networkd-serialize.c:8:1: error: included header fileio.h is not used directly [misc-include-cleaner,-warnings-as-errors]
    8 | #include "fileio.h"
      | ^~~~~~~~~~~~~~~~~~~
    9 | #include "hashmap.h"
Suppressed 1 warnings (1 NOLINT).
1 warning treated as error

fixed it myself so we can move on with rc1