Refactorized inefficient usage of std::string and const char[] (part 2).

PKEuS · PKEuS · commit d4765bccc300 · 2014-04-03T14:56:14.000+02:00
diff --git a/test/testmemleak.cpp b/test/testmemleak.cpp
@@ -2476,7 +2476,7 @@ class TestMemleakInFunction : public TestFixture {
               "    char *p = a(len);\n"
               "    delete [] p;\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
 
         check("char *a(char *a)\n"
               "{\n"
@@ -2491,7 +2491,7 @@ class TestMemleakInFunction : public TestFixture {
               "    else\n"
               "        free(p);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
 
         check("char *a()\n"
               "{\n"
@@ -2502,7 +2502,7 @@ class TestMemleakInFunction : public TestFixture {
               "    char *p = a();\n"
               "    free(p);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
         check("gchar *a()\n"
               "{\n"
               "    return g_malloc(10);\n"
@@ -2512,7 +2512,7 @@ class TestMemleakInFunction : public TestFixture {
               "    gchar *p = a();\n"
               "    g_free(p);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
     }
 
     void allocfunc3() {
@@ -2623,7 +2623,7 @@ class TestMemleakInFunction : public TestFixture {
               "   foo(&tmp);\n"
               "   free(tmp);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
         check("void foo(gchar **str)\n"
               "{\n"
               "    g_free(*str);\n"
@@ -2637,7 +2637,7 @@ class TestMemleakInFunction : public TestFixture {
               "   foo(&tmp);\n"
               "   g_free(tmp);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
 
         //#ticket 1789: getcode other function:
         check("void foo(char **str)\n"
@@ -2655,7 +2655,7 @@ class TestMemleakInFunction : public TestFixture {
               "   foo(&tmp);\n"
               "   free(tmp);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
     }
 
 
@@ -2675,7 +2675,7 @@ class TestMemleakInFunction : public TestFixture {
               "\n"
               "    free(expr);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
         check("static FILE* data()\n"
               "{\n"
               "    return fopen(\"data.txt\",\"rt\");\n"
@@ -2691,7 +2691,7 @@ class TestMemleakInFunction : public TestFixture {
               "\n"
               "    g_free(expr);\n"
               "}");
-        ASSERT_EQUALS(std::string(""), errout.str());
+        ASSERT_EQUALS("", errout.str());
     }
 
 
diff --git a/test/testsimplifytokens.cpp b/test/testsimplifytokens.cpp
@@ -5241,8 +5241,7 @@ class TestSimplifyTokens : public TestFixture {
 
     void simplifyTypedef75() { // ticket #2426
         const char code[] = "typedef _Packed struct S { long l; };\n";
-        const std::string expected = "";
-        ASSERT_EQUALS(expected, tok(code));
+        ASSERT_EQUALS("", tok(code));
         ASSERT_EQUALS("", errout.str());
     }
 
diff --git a/test/testtokenize.cpp b/test/testtokenize.cpp
@@ -7103,8 +7103,7 @@ class TestTokenizer : public TestFixture {
     }
 
     void functionpointer4() {
-        const char code[] = ""
-                            "struct S\n"
+        const char code[] = "struct S\n"
                             "{\n"
                             "    typedef void (*FP)();\n"
                             "    virtual FP getFP();\n"
diff --git a/test/testvalueflow.cpp b/test/testvalueflow.cpp
@@ -57,7 +57,7 @@ class TestValueFlow : public TestFixture {
         TEST_CASE(valueFlowSubFunction);
     }
 
-    bool testValueOfX(const std::string &code, unsigned int linenr, int value) {
+    bool testValueOfX(const char code[], unsigned int linenr, int value) {
         Settings settings;
 
         // strcpy cfg
@@ -269,8 +269,8 @@ class TestValueFlow : public TestFixture {
                "  setx(x);\n"
                "  if (x == 1) {}\n"
                "}";
-        ASSERT_EQUALS(true, testValueOfX(std::string("void setx(int x);")+code, 2U, 1));
-        ASSERT_EQUALS(false, testValueOfX(std::string("void setx(int &x);")+code, 2U, 1));
+        ASSERT_EQUALS(true, testValueOfX((std::string("void setx(int x);")+code).c_str(), 2U, 1));
+        ASSERT_EQUALS(false, testValueOfX((std::string("void setx(int &x);")+code).c_str(), 2U, 1));
         ASSERT_EQUALS(true, testValueOfX(code, 2U, 1));
 
         code = "void f(char* x) {\n"

Original file line number	Diff line number	Diff line change
`@@ -5241,8 +5241,7 @@ class TestSimplifyTokens : public TestFixture {`
`5241`	`5241`
`5242`	`5242`	`void simplifyTypedef75() { // ticket #2426`
`5243`	`5243`	`const char code[] = "typedef _Packed struct S { long l; };\n";`
`5244`		`- const std::string expected = "";`
`5245`		`- ASSERT_EQUALS(expected, tok(code));`
	`5244`	`+ ASSERT_EQUALS("", tok(code));`
`5246`	`5245`	`ASSERT_EQUALS("", errout.str());`
`5247`	`5246`	`}`
`5248`	`5247`
Original file line number	Diff line number	Diff line change
`@@ -7103,8 +7103,7 @@ class TestTokenizer : public TestFixture {`
`7103`	`7103`	`}`
`7104`	`7104`
`7105`	`7105`	`void functionpointer4() {`
`7106`		`- const char code[] = ""`
`7107`		`- "struct S\n"`
	`7106`	`+ const char code[] = "struct S\n"`
`7108`	`7107`	`"{\n"`
`7109`	`7108`	`" typedef void (*FP)();\n"`
`7110`	`7109`	`" virtual FP getFP();\n"`