fix: improve lightning payment failure messages#741
Open
ben-kaufman wants to merge 5 commits intomasterfrom
Open
fix: improve lightning payment failure messages#741ben-kaufman wants to merge 5 commits intomasterfrom
ben-kaufman wants to merge 5 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
jvsena42
approved these changes
Jan 30, 2026
Member
jvsena42
left a comment
There was a problem hiding this comment.
insuficient-inbound-recipient.webm
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #736
This PR improves Lightning payment failure error messages by parsing the
PaymentFailureReasonfrom LDK-node and displaying user-friendly, actionable messages instead of a generic "Your instant payment failed" toast.Description
Previously, all Lightning payment failures showed the same generic error message regardless of the actual cause. This made it impossible for users to understand why their payment failed or what action to take.
The PR maps
PaymentFailureReasonenum values to specific user-friendly messages:RECIPIENT_REJECTEDRETRIES_EXHAUSTEDROUTE_NOT_FOUNDPAYMENT_EXPIREDPreview
QA Notes
1. Test payment failure messages
2. Test QuickPay flow
3. Test background notifications
4. Regression