Skip to content

Conversation

@greg0ire
Copy link
Contributor

@weaverryan weaverryan added the Waiting Code Merge Docs for features pending to be merged label Nov 21, 2017
@greg0ire
Copy link
Contributor Author

greg0ire commented Dec 1, 2017

I wonder if should add a table to recommend a usage:

  • strict: recommended for actively maintained projects with few dependencies
  • <some_integer> recommended to transition towards strictness
  • weak_lagging_vendors: recommended in projects when strict cannot be attained
  • weak_vendors: recommended in libraries that struggle to keep up with deprecations
  • weak: not recommended

@greg0ire greg0ire force-pushed the weak_lagging_vendors branch from 6301a75 to 9e6d8b0 Compare January 29, 2018 18:42
@greg0ire greg0ire changed the title Document weak lagging vendors mode Document allow outdated vendors mode Jan 29, 2018
@greg0ire
Copy link
Contributor Author

Here is how the table looks:

screenshot-2018-1-29 the phpunit bridge symfony framework documentation documentation

own dependencies, meaning they do not fix deprecations as soon as
possible, which means there is nothing you can do to fix that (apart
from a pull request on the outdated vendor). This mode allows you to
ignore those deprecations, allowing you to notice when your code is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe display your code bold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even better, italics.


+------------------------+-----------------------------------------------------+
| Mode | Recommended situation |
+========================+=====================================================+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended repeats a lot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure what to do about that…

@greg0ire greg0ire force-pushed the weak_lagging_vendors branch from eea6f57 to e7dee0c Compare January 30, 2018 07:44
@javiereguiluz
Copy link
Member

@greg0ire the related PR (symfony/symfony#24867) was closed. Could you please tell us if this PR is still relevant or another one is needed to document the changes mentioned in the closed PR? Thanks!

@greg0ire
Copy link
Contributor Author

greg0ire commented Feb 9, 2018

@javiereguiluz this should be closed for now, sorry for leaving it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review Waiting Code Merge Docs for features pending to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants