[Routing] @Route is usable without SensioFrameworkBundle since 3.4
#8016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jun 17, 2017
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
What about @method - does that still require extra bundle?
configuration/micro_kernel_trait.rst
Outdated
| .. code-block:: bash | ||
| $ composer require sensio/framework-extra-bundle | ||
| $ composer require doctrine/annotations |
Member
There was a problem hiding this comment.
Since the article requires symfony/symfony above, will doctrine annotations already be downloaded? I wasn't sure
Contributor
Author
There was a problem hiding this comment.
That's a good point, symfony/symfony requires doctrine/common which requires itself doctrine/annotations so this section can indeed be removed. Thanks!
Contributor
Author
|
@weaverryan |
Member
|
But instead of the |
Contributor
Author
|
@xabbuh indeed I just removed uses of |
xabbuh
approved these changes
Jun 27, 2017
Member
|
Thank you @GuilhemN. |
xabbuh
added a commit
that referenced
this pull request
Jul 4, 2017
…dle since 3.4 (GuilhemN) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #8016). Discussion ---------- [Routing] `@Route` is usable without SensioFrameworkBundle since 3.4 Since symfony/symfony#23044, annotation routes are supported by the framework bundle. So I think we should push using the annotation of the Routing component instead of the one of SensioFrameworkExtraBundle. Commits ------- c0e466a [Routing] is usable without SensioFrameworkBundle since 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/symfony#23044, annotation routes are supported by the framework bundle. So I think we should push using the annotation of the Routing component instead of the one of SensioFrameworkExtraBundle.