Minor tweaks for the article that explains the new 3.3 DI features #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Javier - I appreciate having a more clear term than opt-in for everyone :) |
weaverryan
added a commit
that referenced
this pull request
May 21, 2017
… features (javiereguiluz) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #7930). Discussion ---------- Minor tweaks for the article that explains the new 3.3 DI features This proposes some minor changes to #7921. I propose to replace "opt-in" by "optional" because the first one is uncommon for lots of non native English speakers (Google returns 562 million results for "optional" but only 16 million results for "opt-in"). Commits ------- c49b176 Minor tweaks for the article that explains the new 3.3 DI features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes some minor changes to #7921.
I propose to replace "opt-in" by "optional" because the first one is uncommon for lots of non native English speakers (Google returns 562 million results for "optional" but only 16 million results for "opt-in").