Skip to content

Documented the arguments of the Cookie class #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz wants to merge 1 commit into from
Closed

Documented the arguments of the Cookie class #6436

javiereguiluz wants to merge 1 commit into from

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Apr 5, 2016

Q A
Doc fix? no
New docs? yes
Applies to master (3.1+)
Fixed tickets none (but symfony/symfony#18105 added the $raw argument)

@jakzal jakzal mentioned this pull request Apr 5, 2016
Merged
@xabbuh
Copy link
Member

xabbuh commented Apr 6, 2016

Thanks for taking care of this Javier! What do you think if we first documented all parameters in lower versions and only add documentation for the new $raw argument in the master branch?

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Apr 7, 2016

@xabbuh you are right. Closing it in favor of #6441.

@javiereguiluz javiereguiluz deleted the raw_cookies branch May 24, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@javiereguiluz @xabbuh