mention routing from the database #6021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
@ParamConverter should be enclosed with double backticks.
Contributor
Author
There was a problem hiding this comment.
ah darn. fixed.
|
nice :-) |
Member
There was a problem hiding this comment.
You also need to add a reference to /cookbook/routing/map.rst.inc.
Contributor
Author
|
i updated to all the feedback. anything left to do? |
Contributor
Author
|
ping @weaverryan is there a reason to not merge this? happy to correct things if you can tell me what i should change. |
weaverryan
added a commit
that referenced
this pull request
Feb 16, 2016
This PR was merged into the 2.3 branch. Discussion ---------- mention routing from the database | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #2186, relates to #5709 if we merge #6020, we might want to put this as subsection of the extending_routing section Commits ------- c458431 mention routing from the database
Member
|
@dbu no reason at all - sorry for the delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we merge #6020, we might want to put this as subsection of the extending_routing section