[WCM] Added documentation for the new OptionsResolver flags #3731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Mar 28, 2014
webmozart
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#10616) |
| Applies to | 2.5+ |
| Fixed tickets | - |
Member
There was a problem hiding this comment.
Dealing with Errors (with is a closed class word)
Member
|
You are missing a versionadded directive |
Member
There was a problem hiding this comment.
shouldn't we use OptionsResolverInterface::REMOVE_UNKNOWN here rather than REMOVE_UNKNOWN, to make it clear that these are constants on the interface ?
wouterj
changed the title
Contributor
Author
|
The corresponding PR was closed. This is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.