[RateLimiter] Return getRetryAfter() method usage
#19205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Dec 9, 2023
Member
wouterj
left a comment
wouterj
left a comment
There was a problem hiding this comment.
You're 100% correct that we shouldn't use this (internal) method as public API.
| $headers = [ | ||
| 'X-RateLimit-Remaining' => $limit->getRemainingTokens(), | ||
| 'X-RateLimit-Retry-After' => $limit->calculateTimeForTokens(1, 1), | ||
| 'X-RateLimit-Retry-After' => $limit->getRetryAfter()->getTimestamp(), |
Member
There was a problem hiding this comment.
The header must contain the number of seconds from now to retry I believe. So we can do something like:
Suggested change
| 'X-RateLimit-Retry-After' => $limit->getRetryAfter()->getTimestamp(), | |
| 'X-RateLimit-Retry-After' => now() - $limit->getRetryAfter()->getTimestamp(), |
And then add use function Symfony\Component\Clock\now; at the top of the example.
Contributor
|
I will take of the comments while merging, using - 'X-RateLimit-Retry-After' => now() - $limit->getRetryAfter()->getTimestamp(),
+ 'X-RateLimit-Retry-After' => $limit->getRetryAfter()->getTimestamp() - time(), |
OskarStark
force-pushed
the
fix_rate_limiter_page
branch
from
4731402 to
c61dc1f
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use
RateLimit->calculateTimeForTokens(1, 1)there, bcs it is fromSlidingWindowclass