Skip to content

[AssetMapper] Exclude dot files #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OskarStark merged 1 commit into from
Nov 28, 2023
Merged

[AssetMapper] Exclude dot files #19188

OskarStark merged 1 commit into from
Nov 28, 2023

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Nov 26, 2023

Fix #19182

@carsonbot carsonbot added this to the 7.1 milestone Nov 26, 2023
smnandre
smnandre reviewed Nov 28, 2023
View reviewed changes
frontend/asset_mapper.rst
This option is enabled by default.

.. versionadded:: 7.1
Copy link
Member

@smnandre smnandre Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.4 (just in time 😅 )

Copy link
Contributor

@OskarStark OskarStark Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed while merging

Copy link
Member Author

@alexandre-daubois alexandre-daubois Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks!

@OskarStark OskarStark changed the base branch from 7.1 to 6.4 November 28, 2023 08:02
@OskarStark OskarStark requested a review from xabbuh as a code owner November 28, 2023 08:02
@OskarStark
Copy link
Contributor

OskarStark commented Nov 28, 2023

Thank you Alexandre.

@OskarStark OskarStark merged commit 339f144 into symfony:6.4 Nov 28, 2023
@OskarStark OskarStark modified the milestones: 7.1, 6.4 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

+1 more reviewer

@smnandre smnandre smnandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AssetMapper Status: Needs Review

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[AssetMapper] Exclude dot files

4 participants

@alexandre-daubois @OskarStark @smnandre @carsonbot