[Clock] Add DatePoint
#18932
Merged
[Clock] Add DatePoint
#18932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
date-point
branch
from
cd23d15 to
5d75dcd
Compare
Member
There was a problem hiding this comment.
I would swap the main purpose and the "big advantage" below. (I would also not use "big advantage", that's too subjective)
The main feature of the class is to be bound to the global clock managed by the component, the strictness (and consist behavior across versions of PHP) is bonus.
We might also tell that all clock implementations in the component return a DatePoint?
alexandre-daubois
force-pushed
the
date-point
branch
from
5d75dcd to
4aca469
Compare
Member
Author
|
Thank you for your comment, I reworded the whole section by taking your feedback into account 👍 |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
thanks, here are some proposals
alexandre-daubois
force-pushed
the
date-point
branch
2 times, most recently
from
0c23e95 to
38698e2
Compare
nicolas-grekas
approved these changes
Sep 27, 2023
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM once my two remaining comments are handled, thanks!
alexandre-daubois
force-pushed
the
date-point
branch
from
38698e2 to
2a88325
Compare
wouterj
requested changes
Sep 28, 2023
alexandre-daubois
force-pushed
the
date-point
branch
from
2a88325 to
f14bc14
Compare
wouterj
approved these changes
Sep 29, 2023
Contributor
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18930