[Form] Added AbstractChoiceLoader
#18804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
abstract-choice-loader
branch
from
3923b5f to
ccb2ab9
Compare
HeahDude
reviewed
Aug 30, 2023
Contributor
HeahDude
left a comment
HeahDude
left a comment
There was a problem hiding this comment.
Thanks for documenting this :)
| This abstract class allows to save some boilerplate by implementing some | ||
| of the :class:`Symfony\\Component\\Form\\ChoiceList\\Loader\\ChoiceLoaderInterface` | ||
| methods. Thus, you'll only have to implement the | ||
| :class:`Symfony\\Component\\Form\\ChoiceList\\Loader\\AbstractChoiceLoader::loadChoices` |
Contributor
There was a problem hiding this comment.
Suggested change
| :class:`Symfony\\Component\\Form\\ChoiceList\\Loader\\AbstractChoiceLoader::loadChoices` | |
| :method:`Symfony\\Component\\Form\\ChoiceList\\Loader\\AbstractChoiceLoader::loadChoices` |
Member
Author
There was a problem hiding this comment.
Fixed, thanks!
alexandre-daubois
force-pushed
the
abstract-choice-loader
branch
from
ccb2ab9 to
37c4df7
Compare
Member
|
Alex, thanks for contributing this missing doc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13120
If this one's closed, then this is the last one of the 5.1 milestone 😄