[Messenger] Add RunProcessMessage, RunCommandMessage and PingWebhookMessage
#18631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
approved these changes
Jul 29, 2023
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
8474e98 to
a4ff0c7
Compare
OskarStark
reviewed
Jul 29, 2023
94noni
reviewed
Jul 29, 2023
This was referenced Jul 30, 2023
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
a4ff0c7 to
1d86bd5
Compare
alexandre-daubois
changed the title
RunProcessMessageRunProcessMessage, RunCommandMessage and PingWebhookMessage
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
1d86bd5 to
bb8239d
Compare
Member
Author
|
@OskarStark that's update 👍 |
94noni
reviewed
Jul 30, 2023
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
bb8239d to
be38ac0
Compare
kbond
reviewed
Jul 31, 2023
| ]); | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Note similar to above that a ResponseInterface is returned from the handler?
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
be38ac0 to
4b688bb
Compare
kbond
reviewed
Jul 31, 2023
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
4b688bb to
7544680
Compare
kbond
reviewed
Jul 31, 2023
alexandre-daubois
force-pushed
the
runprocess-message
branch
from
7544680 to
91a358e
Compare
Member
|
What a great contribution (fixing 3 issues!), what a nice feature and what an amazing review process. Thank you all for being so marvelous 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunProcessMessageand `RunProcessMessageHand… #18629PingWebhookMessageand `PingWebhookMessag… #18636RunCommandMessageand `RunCommandMessageHand… #18643