Skip to content

[HtmlSanitizer] Fix API usage on PHP config files #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Mar 21, 2023
Merged

[HtmlSanitizer] Fix API usage on PHP config files #18029

javiereguiluz merged 1 commit into from
Mar 21, 2023

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Mar 8, 2023

Fixes #18024

@OskarStark
Copy link
Contributor

OskarStark commented Mar 8, 2023

Friendly ping @tgalopin

@javiereguiluz javiereguiluz added this to the 6.2 milestone Mar 21, 2023
@javiereguiluz
Copy link
Member

javiereguiluz commented Mar 21, 2023

I'm merging this because it looks correct. See:

https://github.com/symfony/symfony/blob/38b59925ab22530a626a6e5a94e4c4d8ee342c6a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L2929-L2931

and:
https://github.com/symfony/symfony/blob/38b59925ab22530a626a6e5a94e4c4d8ee342c6a/src/Symfony/Component/HtmlSanitizer/HtmlSanitizerConfig.php#L260

Thanks Alex for fixing all these issues!

@javiereguiluz javiereguiluz merged commit a8c5c53 into symfony:6.2 Mar 21, 2023
@alexandre-daubois alexandre-daubois deleted the fix-htmlsanitizer-api branch March 21, 2023 14:56
weaverryan pushed a commit that referenced this pull request Mar 28, 2023
@javiereguiluz @weaverryan
minor #18029 [HtmlSanitizer] Fix API usage on PHP config files (alexa…
f4612fb 
…ndre-daubois)

This PR was merged into the 6.2 branch.

Discussion
----------

[HtmlSanitizer] Fix API usage on PHP config files

Fixes #18024

Commits
-------

2c8a35d [HtmlSanitizer] Fix API usage on PHP config files
weaverryan added a commit that referenced this pull request Mar 28, 2023
@weaverryan
Merge branch '6.2' into 6.3
0c30c95 
* 6.2:
  feature #17513 [Security] Use expression for `#[IsGranted()]` subject (HypeMC)
  minor #18114 update default value for framework.ide (GromNaN)
  minor #18018 [Messenger] add `WorkerRateLimitedEvent` (MrYamous)
  minor #18081 Update events.rst (hbgamra)
  minor #18091 [Doctrine] replace ManagerRegistry in doctrine associations doc (MrYamous)
  minor #18029 [HtmlSanitizer] Fix API usage on PHP config files (alexandre-daubois)
  Move Notifier bridges doc to the code repo README files
  Add note about custom port configuration being ignored by specific mailer transport DSN
  [Notifier] Add link to readme bridges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

HtmlSanitizer Status: Reviewed

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[HTML Sanitizer] PHP-Config with fluent interface examples don't work

4 participants

@alexandre-daubois @OskarStark @javiereguiluz @carsonbot