Skip to content

[HttpClient] Add withOptions() to HttplugClient and Psr18Client #17756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Jan 18, 2023
Merged

[HttpClient] Add withOptions() to HttplugClient and Psr18Client #17756

javiereguiluz merged 1 commit into from
Jan 18, 2023

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jan 16, 2023

Resolves #17382

OskarStark
OskarStark reviewed Jan 16, 2023
View reviewed changes
@alexandre-daubois alexandre-daubois force-pushed the httplug-psr18-with-options branch from 4dae295 to 3b411f1 Compare January 16, 2023 18:58
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jan 16, 2023 •
edited
Loading

I should have thought of it 😄 , thank you for the review! That's updated

@javiereguiluz javiereguiluz added this to the 6.2 milestone Jan 18, 2023
@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 18, 2023 •
edited
Loading

Thank you Alex.

@javiereguiluz javiereguiluz merged commit a4c08b8 into symfony:6.2 Jan 18, 2023
@alexandre-daubois alexandre-daubois deleted the httplug-psr18-with-options branch January 18, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark left review comments

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees

No one assigned

Labels

HttpClient Status: Reviewed

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[HttpClient] Add withOptions() to HttplugClient and Psr18Client

4 participants

@alexandre-daubois @javiereguiluz @OskarStark @carsonbot