[Messenger] remove wrong versionadded for AsMessageHandler
#17493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as this attribute was added in 5.4 (Class exist in 5.4 branch and this post mention it too https://symfony.com/blog/new-in-symfony-5-4-messenger-improvements). This message is also not present in 6.0 branch but present on 6.1, 6.2 and 6.3 branches, this may be an error. .. versionadded:: 6.1 Support for ``#[AsMessageHandler]`` on methods was introduced in Symfony 6.1.
Ehyiah
changed the title
OskarStark
changed the title
versionadded for AsMessageHandler
Contributor
|
Based on the code PR The 👎 from my side on this PR unless I am missing something |
Author
|
Oh my, i'm sorry, I was the one missing something, you are indeed right ! |
Contributor
No problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as this attribute was added in 5.4 (Class exist in 5.4 branch and this post mention it too https://symfony.com/blog/new-in-symfony-5-4-messenger-improvements).
This message is also not present in 6.0 branch but present on 6.1, 6.2 and 6.3 branches, this may be an error.
.. versionadded:: 6.1
Support for
#[AsMessageHandler]on methods was introduced in Symfony 6.1.