[Messenger] Removing note docblock for MessageHandlerInterface
#17332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docblock note is no longer required from Symfony 6.0 onwards as it requires PHP 8.0.
xabbuh
approved these changes
Oct 8, 2022
Member
|
Thank you Maxime. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 11, 2022
…treluingne) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Messenger] Deprecate `MessageSubscriberInterface` Fixes #17319 For `MessageHandlerInterface` class, it's not necessary to create a deprecation directive because we display it more since Symfony 5.3 in Symfony doc. I have created a PR #17332 for removing note block as it is no longer necessary in Symfony 6.0. Commits ------- cb957d7 [Messenger] Deprecate `MessageSubscriberInterface`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docblock note is no longer necessary required from Symfony 6.0 onwards as it requires PHP 8.0.
What do you think?