[DependencyInjection] Document remove() method on the PHP configurator #17098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
javiereguiluz
added a commit
that referenced
this pull request
Aug 3, 2022
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Enable code blocks Revert 8f250a2 Revert fb505de from #17020 Tests were broken, see that example from #17098: ``` Run composer config --no-plugins allow-plugins.symfony/flex true Error: File "./composer.json" cannot be found in the current directory In ConfigCommand.php line 206: File "./composer.json" cannot be found in the current directory config [-g|--global] [-e|--editor] [-a|--auth] [--unset] [-l|--list] [-f|--file FILE] [--absolute] [-j|--json] [-m|--merge] [--append] [--source] [--] [<setting-key> [<setting-value>...]] Error: Process completed with exit code 1. ``` [full output](https://github.com/symfony/symfony-docs/runs/7640214086?check_suite_focus=true) It should not be necessary now that symfony-tools/symfony-application#14 has been merged. Commits ------- 7bff8b5 Enable code blocks
Contributor
|
Should we add that |
Contributor
Author
|
closing here |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jun 9, 2023
…or` remove method (alamirault) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Document `ServiceConfigurator` remove method Continue work started by `@94noni` in symfony#17098 Fix symfony#14854 Commits ------- 3d9dfe6 [DependencyInjection] Document ServiceConfigurator remove method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14854
I do not know if it is a proper explanation, feel free to challenge :)