Fix doc service deprecation #16952
Merged
Fix doc service deprecation #16952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
force-pushed
the
fix-doc-service-deprecation
branch
from
18e62cd to
6026bf8
Compare
HeahDude
approved these changes
Jul 8, 2022
Contributor
HeahDude
left a comment
HeahDude
left a comment
There was a problem hiding this comment.
Should target 5.4, mentioning that passing only one argument is deprecated since 5.1 (ref symfony/symfony#35778)
javiereguiluz
force-pushed
the
fix-doc-service-deprecation
branch
from
6026bf8 to
ffdb7e6
Compare
Member
|
Thanks Antoine for the contribution! Thanks Jules for the review. We did those tweaks while merging. See 976422a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Based on this PR, I've followed the doc
But when tests executed, I got this error
So I propose to fix the doc accordingly here
Thank you