Skip to content

[Console] Document SymfonyStyle additions #15975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Oct 30, 2021
Merged

[Console] Document SymfonyStyle additions #15975

javiereguiluz merged 1 commit into from
Oct 30, 2021

Conversation

@kbond
Copy link
Member

@kbond kbond commented Oct 21, 2021

Docs for symfony/symfony#43595.

Fixes #15969.

@carsonbot carsonbot added this to the 5.4 milestone Oct 21, 2021
@kbond
Copy link
Member Author

kbond commented Oct 21, 2021 •
edited
Loading

When I built the docs using the new system, the generated docs in _build/output were not styled and missing stuff so I wasn't able to confirm this looks correct...

Edit, I was able to correct this by upgrading symfony-tools/doc-builder and build.php.

kbond
kbond commented Oct 21, 2021
View reviewed changes
@javiereguiluz javiereguiluz merged commit b871d8e into symfony:5.4 Oct 30, 2021
@javiereguiluz
Copy link
Member

javiereguiluz commented Oct 30, 2021

Thanks Kevin!

@kbond kbond deleted the console-style-update branch October 30, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees

No one assigned

Labels

Console Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Console] SymfonyStyle enhancements

3 participants

@kbond @javiereguiluz @carsonbot