Skip to content

[String] Document trimPrefix() and trimSufix() methods #15951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Oct 20, 2021
Merged

[String] Document trimPrefix() and trimSufix() methods #15951

javiereguiluz merged 1 commit into from
Oct 20, 2021

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Oct 19, 2021

Fixes #15931.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Oct 19, 2021
@javiereguiluz javiereguiluz merged commit a579a36 into symfony:5.4 Oct 20, 2021
nicolas-grekas
nicolas-grekas reviewed Oct 20, 2021
View reviewed changes
@javiereguiluz javiereguiluz deleted the fix_15931 branch October 20, 2021 13:29
@javiereguiluz javiereguiluz mentioned this pull request Oct 20, 2021
Merged
javiereguiluz added a commit that referenced this pull request Oct 20, 2021
@javiereguiluz
minor #15968 [String] Fix the explanation of trimPrefix and trimSuffi…
c733953 
…x (javiereguiluz)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[String] Fix the explanation of trimPrefix and trimSuffix

Fixes #15951.

Commits
-------

38bfd69 [String] Fix the explanation of trimPrefix and trimSuffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Status: Reviewed String

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[String] Add trimSuffix() and trimPrefix() methods

4 participants

@javiereguiluz @nicolas-grekas @OskarStark @carsonbot