Re-adding , '@session.flash_bag' #15184
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was there in 4.4: https://symfony.com/doc/4.4/session.html#basic-usage But when I omit it, I'm getting (Symfony 5.2): > Circular reference detected for service "session", path: "session -> session.flash_bag -> session". TODO: PHP config is missing for this code block. I'm doing it like this - should I make a PR? (But I don't know the XML way) ```php use function Symfony\Component\DependencyInjection\Loader\Configurator\service; use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag; use Symfony\Component\HttpFoundation\Session\Session; $services->set('session', Session::class)->public()->args([service('session.storage'), service('session.namespacedattributebag')]); $services->set('session.namespacedattributebag', NamespacedAttributeBag::class); ```
Contributor
Author
|
Actually, I'm not sure anymore about this. When passing
But when not passing it, I'm getting the circular reference exception (see above), which should have been fixed by symfony/symfony#36261 So what's the status now? |
Member
|
I'm closing here, it seems like another contribution was merged that re-added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was there in 4.4: https://symfony.com/doc/4.4/session.html#basic-usage
But when I omit it, I'm getting (Symfony 5.2):
TODO: PHP config is missing for this code block. I'm doing it like this - should I make a PR? (But I don't know the XML way)