Skip to content

Conversation

@wkania
Copy link
Contributor

@wkania wkania commented Nov 14, 2020

No description provided.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@javiereguiluz
Copy link
Member

@wkania thanks for this improvement. For future pull requests, please note that Symfony 3.4 is no longer maintained, so new pull requests should be mage against a supported branch. Here you can find the list of currently maintained branches: https://symfony.com/releases Thanks!

@javiereguiluz javiereguiluz changed the base branch from 3.4 to 4.4 November 15, 2020 09:22
@javiereguiluz javiereguiluz merged commit 07cc24e into symfony:4.4 Nov 15, 2020
@wkania
Copy link
Contributor Author

wkania commented Nov 15, 2020

@javiereguiluz Thank you for the info. My knowledge about the oldest maintened version was from the documentation. From what I see it's still maintened for few more days.

image

@javiereguiluz
Copy link
Member

@wkania you are absolutely right! I'm sorry.

3.4 is STILL maintained for a few days (until November 2020 ends). However, we decided to no longer merge changes in that branch to avoid introducing mistakes now that we're so close to end its support. So, you did it perfectly right (thanks for that!) but we prefer to no longer merge in 3.4. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants