Translatable objects #14240
Merged
Translatable objects #14240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfelbox
reviewed
Sep 15, 2020
javiereguiluz
added
Status: Reviewed
Translation
and removed
Status: Needs Review
labels
javiereguiluz
force-pushed
the
translatable-objects
branch
from
d463334 to
a2ad274
Compare
Member
|
Nate, thanks a lot for contributing both this feature and its docs. People love the new feature and this was a great first contribution to Symfony Docs. Congrats on that too! Please note that while merging we did some rewords based on this blog post -> https://symfony.com/blog/new-in-symfony-5-2-translatable-objects. but we kept the core of your contribution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Add docs for translatable objects.
Feature: symfony/symfony#37670
Fixes #14145
Unsure how in-depth the docs should go. Open to feedback and collaboration.