Skip to content

Document that cache warmers now must return an array of files to preload #13516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
May 18, 2020
Merged

Document that cache warmers now must return an array of files to preload #13516

javiereguiluz merged 1 commit into from
May 18, 2020

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Apr 10, 2020

Fixes #13493.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Apr 10, 2020
noniagriconomie
noniagriconomie reviewed Apr 12, 2020
View reviewed changes
@javiereguiluz
Copy link
Member Author

javiereguiluz commented Apr 23, 2020

I've reworded this entirely after asking @nicolas-grekas about this and he explained to me how this works. Thanks!

@javiereguiluz javiereguiluz changed the base branch from master to 5.1 May 18, 2020 11:28
@javiereguiluz javiereguiluz merged commit 635370d into symfony:5.1 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@jmsche jmsche jmsche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

HttpKernel Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

[HttpKernel] allow cache warmers to add to the list of preloaded classe…

4 participants

@javiereguiluz @jmsche @noniagriconomie @carsonbot